Upgrades Next.js from 8.x.x to 9.x.x #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,7 @@ import yar from 'yar'; | |||
| import cleanup from 'node-cleanup'; | |||
| import acceptLanguagePlugin from 'hapi-accept-language2'; | |||
| import hapiDevErrors from 'hapi-dev-errors'; | |||
| import next from 'next'; | |||
| const next = require('next'); | |||
There was a problem hiding this comment.
Hadn't seen require and import mixed in the same file before. Is this required for the new version of Next, I see the same change in another file.
There was a problem hiding this comment.
You know, I was following Fiona’s lead with the PR she made in preparation for this, but I didn’t actually test whether this syntax is necessary anymore... I’ll do so and update the PR.
There was a problem hiding this comment.
Ok, no prob. I don't see it as it blocker if it's working. I would guess, if turning require into an import still works then I'd chuck-it to her just forgetting/copy-pasting. I'd done the same plenty of times lol. Just had the Q 💃
phillipbentonkelly
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #458 and upgrades Next.js to latest across all apps except for 311; after upgrading (along with Babel from 7.1.x to 7.6.x), running Jest throws
Since 311 is not currently in production and it’s unknown whether it ever will be, it was decided to leave it as-is for the time being rather than spend more time troubleshooting.