Migrate to python 3.12 #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matti-lamppu
force-pushed
the
python-312-update
branch
from
3c1b800 to
cacdc10
Compare
|
@ranta If we want to migrate to 3.12, we need to remove all snapshot tests, since the library requires the There is an open issue about this, but little activity. |
|
I don't think we are in any hurry to upgrade to 3.12. We can start slowly refactoring away the snapshot tests along with all of the other refactoring stuffs and upgrade python at some later point :) |
matti-lamppu
force-pushed
the
python-312-update
branch
from
cacdc10 to
5c25190
Compare
matti-lamppu
force-pushed
the
python-312-update
branch
4 times, most recently
from
49c6a63 to
e0315a6
Compare
matti-lamppu
force-pushed
the
python-312-update
branch
from
e0315a6 to
63ef459
Compare
matti-lamppu
force-pushed
the
python-312-update
branch
from
63ef459 to
c4f5e73
Compare
matti-lamppu
force-pushed
the
python-312-update
branch
from
c4f5e73 to
baf1497
Compare
matti-lamppu
force-pushed
the
python-312-update
branch
from
baf1497 to
b592c40
Compare
matti-lamppu
force-pushed
the
python-312-update
branch
2 times, most recently
from
ee29c0e to
bdd1147
Compare
matti-lamppu
force-pushed
the
python-312-update
branch
2 times, most recently
from
0c55b52 to
554bae2
Compare
matti-lamppu
force-pushed
the
python-312-update
branch
2 times, most recently
from
092f096 to
c138bac
Compare
matti-lamppu
force-pushed
the
python-312-update
branch
from
c138bac to
3e2d9cb
Compare
|
ranta
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
🧪 Test plan
poetry env use "<path to python 3.12 executable"->poetry installCI already runs tests and builds image, so those should be tested with that