Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve #317 #618

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Solve #317 #618

merged 2 commits into from
Mar 19, 2018

Conversation

jonnetanninen
Copy link
Contributor

Solves #317

@ghost ghost assigned jonnetanninen Mar 15, 2018
@ghost ghost added the in progress label Mar 15, 2018
@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #618 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
- Coverage   24.88%   24.63%   -0.26%     
==========================================
  Files         121      121              
  Lines        2499     2598      +99     
  Branches      421      439      +18     
==========================================
+ Hits          622      640      +18     
- Misses       1562     1626      +64     
- Partials      315      332      +17
Impacted Files Coverage Δ
server/Html.js 0% <ø> (ø) ⬆️
server/render-middleware.js 0% <ø> (ø) ⬆️
src/components/admin/HearingEditor.js 5% <0%> (+1%) ⬆️
src/actions/index.js 5.88% <0%> (+2.03%) ⬆️
src/reducers/hearing.js 48.27% <0%> (+2.82%) ⬆️
src/components/admin/HearingToolbar.js 15.15% <0%> (+4.04%) ⬆️
src/reducers/hearingEditor/hearing.js 24.39% <0%> (+4.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71fd9d9...2722b94. Read the comment docs.

Copy link
Contributor

@dotanthanh dotanthanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meta tags did appear in source file. Image fetching from localhost is obviously hopeless.

@dotanthanh dotanthanh merged commit 292eb31 into master Mar 19, 2018
@ghost ghost removed the in progress label Mar 19, 2018
@ranta ranta deleted the feature/add-git-hash branch November 23, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants