Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11094: remove sector field from index #518

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Dec 10, 2024

UHF-11094

What was done

Sector fields were added in 6938476 along with with Drupal\paatokset_search\Plugin\search_api\processor\SectorJSON processor.

This processor was removed in 2f59d7a, but its config was left in place. This should fix: https://sentry.hel.fi/organizations/city-of-helsinki/issues/39131/

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-11094-remove-sector
    • make fresh
  • Run make drush-cr

How to test

  • Check that search app works after reindexing.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

Sector fields were added in 6938476
with Drupal\paatokset_search\Plugin\search_api\processor\SectorJSON
processor.

This processor was removed in 2f59d7a.

This should fix: https://sentry.hel.fi/organizations/city-of-helsinki/issues/39131/
@juho-lehmonen juho-lehmonen self-requested a review December 11, 2024 08:38
@hyrsky hyrsky marked this pull request as ready for review December 11, 2024 08:39
Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't replicate this locally either, but looks good!

Base automatically changed from UHF-X-update-platform-config to dev December 12, 2024 07:17
@hyrsky hyrsky merged commit dfa1485 into dev Dec 12, 2024
3 checks passed
@hyrsky hyrsky deleted the UHF-11094-remove-sector branch December 12, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants