Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9367: tests #477

Merged
merged 17 commits into from
Oct 8, 2024
Merged

UHF-9367: tests #477

merged 17 commits into from
Oct 8, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Oct 7, 2024

UHF-9367

What was done

  • Add some tests

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9367-tests
    • make fresh
  • Run make drush-cr

How to test

  • Run ./vendor/bin/phpunit public/modules/custom --coverage-html coverage
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@hyrsky hyrsky force-pushed the UHF-9367-tests branch 3 times, most recently from 11c1c5b to 1aeb13a Compare October 7, 2024 04:31
@juho-lehmonen juho-lehmonen self-requested a review October 7, 2024 08:13
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@hyrsky hyrsky merged commit 2028ad5 into dev Oct 8, 2024
1 of 2 checks passed
@hyrsky hyrsky deleted the UHF-9367-tests branch October 8, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants