Login updates from 4.1 to 3.12. #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If items are added directly to the module array, the array size increases and same modules are added twice on second render.
Memoize array in Login.stories and merge 3 useMemos to one in LoginContext
…f beacon is re-created In a scenario where external modules are used and the component is created multiple times, the listeners are set only once in the modules. This happens in StrictMode. On the second storeBeacon call the listeners in dedicated beacon are not added back and old ones are not removed. The list of listeners must be kept and disposers must be called. Now listeners are added again. Listeners added after a beacon is created are not stored, because those are logically added when second beacon is created - as in first run.
Select exported old ones and Login was missing
ApiToken renewal/update/removal can happen regardless of on-going queries. The renewal should also timeout. This util will track tokens, store them and timeout rewals. The code logic is copied from graphqlModule.
Main function of this module is to automatically append tokens to query headers and wait for on-going apiToken renewals when queries start.
If imports point to apollo/client/core, the apollo/client is not detected to be the one in package.json. Then it is bundled in to the hds-js.
…ntext The import in apolloClientModule.ts cannot be changed, so all bundled modules must be listed in allowedExternals. They are then bundled, but there is no fix.
Similar to ApolloClientModule and GraphQLModule but appends api tokens to fetch requests.
The render process could be too fast for Date.now() to change
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit 5127989. ♻️ This comment has been updated with latest results. |
|
Preview found from hds-demo docs/preview_1456 Demos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picked login updates from 4.1 (development)
Related Issue
Motivation and Context
How Has This Been Tested?
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog