Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add technology tags to documentation #1446

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

timwessman
Copy link
Contributor

@timwessman timwessman commented Nov 27, 2024

Description

  • Technology tags to all components in the documentation (on Components overview page)
  • Add tags to the scaffolding script

To think

  • where Vanilla JS link (on Components overview page) should go?

Related Issue

Closes HDS-1366

Motivation and Context

It would be user friendly if there would be component tags (as Stable, Accessible, etc) that include the packages that it’s in.

How Has This Been Tested?

  • See it in the component overview page in the documentation.
  • Try scaffolding script to chose the core tag (React tag is added automatically)

Demos:

Links to demos are in the comments

Screenshots (if appropriate):

Add to changelog

  • Added needed line to changelog

Copy link

github-actions bot commented Nov 27, 2024

Test Results

  1 files   64 suites   11m 41s ⏱️
 60 tests  60 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit 6c5d488.

♻️ This comment has been updated with latest results.

Copy link

Preview found from hds-demo docs/preview_1446

Demos

Docs
Core Storybook
React Storybook

@NikoHelle
Copy link
Contributor

Looks good! 👍 Can't approve until that JS-link points somewhere 😄

@timwessman timwessman force-pushed the hds-1366-documentation-component-tags branch from c5b793f to 0a2149f Compare December 12, 2024 11:54
@timwessman
Copy link
Contributor Author

Now JS -link points to hds-js section in Getting Started / Developer page.

Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the links work in production, looks good to me

@timwessman timwessman merged commit a38aca5 into development Dec 18, 2024
8 checks passed
@timwessman timwessman deleted the hds-1366-documentation-component-tags branch December 18, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants