-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Release-4.0.0) HDS-2069: Select docs #1389
Conversation
Test Results 1 files 64 suites 11m 56s ⏱️ Results for commit 5221df4. ♻️ This comment has been updated with latest results. |
1baa434
to
90bd052
Compare
Preview found from hds-demo docs/preview_1389 Demos |
90bd052
to
f17d1af
Compare
41d0423
to
3716b8c
Compare
9a2ef76
to
88d404b
Compare
3716b8c
to
b44331d
Compare
88d404b
to
71b671c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I left few small improvement suggestions about documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
71b671c
to
e28bda8
Compare
9c5a242
to
158429d
Compare
c543fe8
to
84b0b81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good, but code examples on documentation use finnish text version (FI:clear all) but examples should be in English for doc site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise Excellent Work!
84b0b81
to
5221df4
Compare
Description
Docs, migration guide and changelog
Related Issue
Closes HDS-2069
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog