Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Release-4.0.0) HDS-2069: Select docs #1389

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

NikoHelle
Copy link
Contributor

@NikoHelle NikoHelle commented Oct 25, 2024

Description

Docs, migration guide and changelog

Related Issue

Closes HDS-2069

Demos:

Links to demos are in the comments

Screenshots (if appropriate):

Add to changelog

  • [ x] Added needed line to changelog

Copy link

github-actions bot commented Oct 25, 2024

Test Results

  1 files   64 suites   11m 56s ⏱️
 60 tests  60 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit 5221df4.

♻️ This comment has been updated with latest results.

Base automatically changed from hds-2069-select-final-part-251024 to feature/hds-2069-select-v4 October 31, 2024 07:09
@NikoHelle NikoHelle force-pushed the hds-2069-select-docs-251024 branch from 1baa434 to 90bd052 Compare October 31, 2024 11:01
Copy link

Preview found from hds-demo docs/preview_1389

Demos

Docs
Core Storybook
React Storybook

@NikoHelle NikoHelle force-pushed the hds-2069-select-docs-251024 branch from 90bd052 to f17d1af Compare October 31, 2024 12:15
@NikoHelle NikoHelle force-pushed the feature/hds-2069-select-v4 branch from 41d0423 to 3716b8c Compare October 31, 2024 13:00
@NikoHelle NikoHelle force-pushed the hds-2069-select-docs-251024 branch 2 times, most recently from 9a2ef76 to 88d404b Compare October 31, 2024 13:07
@NikoHelle NikoHelle force-pushed the feature/hds-2069-select-v4 branch from 3716b8c to b44331d Compare November 4, 2024 11:17
@NikoHelle NikoHelle force-pushed the hds-2069-select-docs-251024 branch from 88d404b to 71b671c Compare November 4, 2024 11:18
Copy link
Contributor

@SillanmakiA SillanmakiA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I left few small improvement suggestions about documentation. ☺️

site/src/docs/components/select/index.mdx Outdated Show resolved Hide resolved
site/src/docs/components/select/index.mdx Outdated Show resolved Hide resolved
site/src/docs/components/select/index.mdx Show resolved Hide resolved
Copy link
Contributor

@nooranen nooranen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Noticed that the component page is missing a title "Select"

Screenshot 2024-11-05 at 11 56 42

@NikoHelle NikoHelle force-pushed the hds-2069-select-docs-251024 branch from 71b671c to e28bda8 Compare November 6, 2024 13:53
@NikoHelle
Copy link
Contributor Author

Good job! Noticed that the component page is missing a title "Select"

Screenshot 2024-11-05 at 11 56 42

Fixed!

@NikoHelle NikoHelle force-pushed the feature/hds-2069-select-v4 branch from 9c5a242 to 158429d Compare November 7, 2024 08:31
Base automatically changed from feature/hds-2069-select-v4 to release-4.0.0 November 7, 2024 10:50
@NikoHelle NikoHelle force-pushed the hds-2069-select-docs-251024 branch 2 times, most recently from c543fe8 to 84b0b81 Compare November 19, 2024 07:11
Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good, but code examples on documentation use finnish text version (FI:clear all) but examples should be in English for doc site.

Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise Excellent Work!

@NikoHelle NikoHelle force-pushed the hds-2069-select-docs-251024 branch from 84b0b81 to 5221df4 Compare November 21, 2024 11:06
@NikoHelle NikoHelle merged commit db7c978 into release-4.0.0 Nov 21, 2024
8 checks passed
@NikoHelle NikoHelle deleted the hds-2069-select-docs-251024 branch November 21, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants