HDS-2245: login strict mode issues #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If modules are given from outside, the array is preserved and inner modules (sessionPollerSettings, apiTokensClient) are added again and again.
NikoHelle
force-pushed
the
hds-2245-login-strict-mode
branch
2 times, most recently
from
f4652cf to
4a978cd
Compare
…eady Kukkuu-ui used the error.message to detect can it be ignored, which is a fail-prone Added a new .util.ts file or hds-js would add React to its bundle.
NikoHelle
force-pushed
the
hds-2245-login-strict-mode
branch
from
4a978cd to
c392a63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Login had issue with external modules and strict mode. Passed array was mishandled.
Added a utility function to detect ignoreable login callback errors. Kukkuu used the error message to detect these, so adding a function would make it less error prone.
Could not add strict mode to Storybook, because there is a add-on that fails. There is a separate ticket for that.
Related Issue
Closes HDS-2245
Motivation and Context
How Has This Been Tested?
Added local test for the function. StrictMode cannot be used in tests.
Demos:
Docs
React. It has strict mode on, because add-on was removed for this.
Screenshots (if appropriate):
Add to changelog