Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS-2244: SSR error document not defined #1270

Merged
merged 4 commits into from
May 7, 2024

Conversation

NikoHelle
Copy link
Contributor

@NikoHelle NikoHelle commented Apr 25, 2024

Description

When rendering with SSR, cookies were read, but document has not defined when attempting "document.cookie"

Closes HDS-2244

Motivation and Context

How Has This Been Tested?

Tested in hds-react-ssr. First with HDS 3.7. and then with this version as a *.tgz. FIle was created with hds-cra.

Add to changelog

  • Added needed line to changelog

@NikoHelle NikoHelle requested a review from a team April 25, 2024 11:23
Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good good 👍

@laurakarhu laurakarhu added this to the HDS 3.8.0 milestone May 3, 2024
Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@NikoHelle NikoHelle merged commit 47d0d0d into development May 7, 2024
7 checks passed
@NikoHelle NikoHelle deleted the hds-2244-no-document-found branch May 7, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants