Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS-2224 playwright initial test #1266

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Conversation

terovirtanen
Copy link
Contributor

@terovirtanen terovirtanen commented Apr 16, 2024

Description

Playwright initial tests
HDS-2224

e2e_tests.yml is a reference workflow to run e2e tests and get test results. E2e should be run a part of hds-demo-preview workflow (HDS-1589).

Related Issue

Closes #

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Add to changelog

  • Added needed line to changelog

Copy link

github-actions bot commented Apr 17, 2024

Test Results

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit f9a87ef.

♻️ This comment has been updated with latest results.

@terovirtanen terovirtanen requested a review from NikoHelle April 17, 2024 05:58
Copy link
Contributor

@NikoHelle NikoHelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gitignore, package.json, playwright.config.js and yarn.lock should be moved to /e2e -folder instead of root.

@terovirtanen terovirtanen requested a review from NikoHelle April 18, 2024 04:53
Copy link
Contributor

@NikoHelle NikoHelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added just some generic comments.

.github/workflows/e2e-tests.yml Show resolved Hide resolved
.github/workflows/e2e-tests.yml Show resolved Hide resolved
e2e/package.json Show resolved Hide resolved
@terovirtanen terovirtanen requested a review from NikoHelle April 22, 2024 04:58
@terovirtanen terovirtanen merged commit 8c4e94f into development Apr 29, 2024
9 checks passed
@terovirtanen terovirtanen deleted the playwright_initial_HDS-2224 branch April 29, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants