fix: Add onblur event for Tooltip parent #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrTuomoK
reviewed
Apr 16, 2024
| @@ -127,6 +127,7 @@ export const Tooltip = ({ | |||
| aria-label={buttonLabel} | |||
| aria-expanded={isTooltipOpen} | |||
| onClick={onButtonClick} | |||
| onBlur={() => setIsTooltipOpen(false)} | |||
There was a problem hiding this comment.
BTW is there a performance issue when using like this instead of using for example const onBlurHandler = () => {setToolTipOpen(false);} outside the render/return and calling it like onBlur={onBlurHandler}. If I remember correctly, React recreates the functions when rendering if declared like onBlur = {() => {}}. But you may prove me wrong :D
There was a problem hiding this comment.
interesting, could be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tooltip parent didn't have an on blur event. Now it has. JIRA HDS-2196
How Has This Been Tested?
Open Tooltip component in Storybooks -> click on (?) -button -> Tooltip comes visible -> press Tab -key -> Tooltip disappers