-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDS-2102: login data to cookie docs #1252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tässä käännöksiä
}, | ||
sv: { | ||
hostName: currentSiteTranslations.sv, | ||
description: '(SV) Käyttäjän kirjautumistiedot tallennetaan selaimen muistiin (session storage).', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Användarens inloggningsuppgifter lagras i webbläsarens minne (session storage).
name: 'hds_login_api_token_storage_key', | ||
fi: { | ||
hostName: currentSiteTranslations.fi, | ||
description: 'Kirjautuneen käyttäjän api tokenit tallennetaan selaimen muistiin (session storage).', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kirjautuneen käyttäjän rajanpinta-avaimet (api tokens) tallennetaan selaimen muistiin (session storage).
}, | ||
sv: { | ||
hostName: currentSiteTranslations.sv, | ||
description: '(SV) Kirjautuneen käyttäjän api tokenit tallennetaan selaimen muistiin (session storage).', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Api-token för en autentiserad användare sparas i webbläsarens minne (session storage).
fi: { | ||
hostName: currentSiteTranslations.fi, | ||
description: | ||
'Kirjautuneen käyttäjän access token tallennetaan selaimen muistiin (session storage), jolla tunnistetaan kenen api tokenit ovat tallessa.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kirjautuneen käyttäjän pääsyoikeudet tallennetaan selaimen muistiin, jotta tunnistetaan kenen rajapinta-avaimet on tallessa.
sv: { | ||
hostName: currentSiteTranslations.sv, | ||
description: | ||
'(SV) Kirjautuneen käyttäjän access token tallennetaan selaimen muistiin (session storage), jolla tunnistetaan kenen api tokenit ovat tallessa.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Den inloggade användarens åtkomsträttigheter lagras i webbläsarens minne för att identifiera vems token som lagras.
@@ -92,6 +92,11 @@ export function getCookieContent() { | |||
const tunnistamoUrl = 'api.hel.fi'; | |||
const keycloakUrl = 'tunnistus.hel.fi'; | |||
const suomiFiUrl = 'suomi.fi'; | |||
const currentSiteTranslations = { | |||
fi: 'Tämä sivusto', | |||
sv: '(SV) Tämä sivusto', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Denna webbsida
4e630d3
to
02e7684
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
02e7684
to
fef0c6b
Compare
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit fef0c6b. |
No code changes, reviewable by anyone!
Description
The login component stores data to session storage. That data should also be listed in the common cookie consents.
Added information about the stored data common cookies and to the docs.
Related Issue
Closes HDS-2102
How Has This Been Tested?
Storybook and docs site tested locally.
Docs demo of the part added to the login component docs.
Docs demo of the cookie pattern where Login component data is listed with other cookie consents.
Storybook demo how consents are listed. Open the "Necessary cookies" > "Login"
Screenshots (if appropriate):
How the new data is shown in the modal:
Add to changelog