Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10132: Move role mapping from helfi_helsinki_profiili to tunnistamo module #41

Merged
merged 5 commits into from
Sep 3, 2024
Merged

UHF-10132: Move role mapping from helfi_helsinki_profiili to tunnistamo module #41

merged 5 commits into from
Sep 3, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Sep 2, 2024 •
edited by jira bot
Loading

UHF-10132

What was done

  • Add loa_roles mapping. This maps Drupal roles to user using loa claim from token.
  • Cleanup some unused/old features.

Other PRs

@hyrsky hyrsky mentioned this pull request Sep 2, 2024
Merged
7 tasks
@hyrsky hyrsky changed the title UHF-10132: admin ad login UHF-10132: Move role mapping from helfi_helsinki_profiili to tunnistamo module Sep 2, 2024
jiisuominen
jiisuominen approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@jiisuominen jiisuominen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working. Tested with these dev branches and logging in works as expected.

@hyrsky hyrsky merged commit 8a48962 into main Sep 3, 2024
3 checks passed
@hyrsky hyrsky deleted the UHF-10132-admin-ad-login branch September 3, 2024 07:23
This was referenced Sep 3, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiisuominen jiisuominen jiisuominen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyrsky @jiisuominen