Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9458: Fix creation of uuid usernames #30

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Jan 8, 2024

With the new client, preferred_username field in userinfo is set to a UUID. This change removes the preferred_username when it is a UUID so that the name field is used instead.

See: https://git.drupalcode.org/project/openid_connect/-/blob/2.x/src/OpenIDConnect.php?ref_type=heads#L545-559

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e53539) 72.95% compared to head (c092bc8) 72.95%.

❗ Current head c092bc8 differs from pull request most recent head 45015e4. Consider uploading reports for the commit 45015e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #30   +/-   ##
=========================================
  Coverage     72.95%   72.95%           
  Complexity       55       55           
=========================================
  Files             4        4           
  Lines           196      196           
=========================================
  Hits            143      143           
  Misses           53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

helfi_tunnistamo.module Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants