Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9213: Run phpstan #162

Merged
merged 4 commits into from
Nov 30, 2023
Merged

UHF-9213: Run phpstan #162

merged 4 commits into from
Nov 30, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Nov 27, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (1c35432) 81.79% compared to head (8db27ab) 81.63%.

❗ Current head 8db27ab differs from pull request most recent head ed7b81e. Consider uploading reports for the commit ed7b81e to get more accurate results

Files Patch % Lines
.../FieldFormatter/ErrandServicesChannelFormatter.php 0.00% 8 Missing ⚠️
src/Plugin/views/filter/ProvidedLanguages.php 0.00% 4 Missing ⚠️
src/Entity/Form/ContentEntityForm.php 0.00% 3 Missing ⚠️
src/Entity/Listing/ListBuilder.php 0.00% 2 Missing ⚠️
src/Entity/OntologyWordDetails.php 0.00% 2 Missing ⚠️
src/Plugin/migrate/source/ServiceMap.php 0.00% 1 Missing ⚠️
src/Plugin/views/filter/Status.php 0.00% 1 Missing ⚠️
...c/Plugin/views/relationship/TagOwdRelationship.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #162      +/-   ##
============================================
- Coverage     81.79%   81.63%   -0.16%     
- Complexity      360      361       +1     
============================================
  Files            50       50              
  Lines          2873     2881       +8     
============================================
+ Hits           2350     2352       +2     
- Misses          523      529       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyrsky hyrsky self-requested a review November 30, 2023 07:28
src/Entity/OntologyWordDetails.php Show resolved Hide resolved
src/Entity/TprEntityBase.php Outdated Show resolved Hide resolved
Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this already, since I tested/reviewed all other changes and I don't thing addressing those comments needs re-approval (and the current code already works).

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants