UHF-9159 subgroup

[dire]

UHF-9159

What was done?

• Added new field subgroup to TPR units.
• Added tests for the new field.

How to install

• Make sure your KASKO instance is up and running.
  • make fresh
• Chance the branch to get correct configs: git checkout UHF-9159_subgroup-kasko-configs.
• Run composer require drupal/helfi_tpr:dev-UHF-9159_subgroup
• Run composer require drupal/helfi_platform_config:dev-UHF-9159_subgroup-field-conf
• Run composer require drupal/hdbt:dev-UHF-9159_subgroup-accordion
• Run make drush-updb drush-cim drush-locale-update drush-cr.

How to test

Testing the new field and migration

• Database update ran nicely.
• Run the migration drush migrate:import tpr_unit --idlist 10404:fi,10404:sv,10404:en --update. It should also run nicely without errors.
• Check https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/admin/content/integrations/tpr-unit/10404/edit and that the new field Subgroup is there under heading "Contact details of daycare centre groups".
• Check that the field labels are translated (might need to change the UI language from user settings).
• Check that the subgroups are displayed nicely in an accordion https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/paivakoti-aalto.
• The accordion heading is translated in all three languages.
• In other instances this field should be hidden in form and view displays.

Run the tests

Run following in the /app inside the container.

• Run vendor/bin/phpunit -c /app/phpunit.xml.dist public/modules/contrib/helfi_tpr/tests/src/Unit/ConnectionRepositoryTest.php
• Run vendor/bin/phpunit -c /app/phpunit.xml.dist public/modules/contrib/helfi_tpr/tests/src/Unit/ConnectionTest.php
• Run vendor/bin/phpunit -c /app/phpunit.xml.dist public/modules/contrib/helfi_tpr/tests/src/Kernel/UnitMigrationTest.php

All tests should pass.

Other PRs

• Check also UHF-9159: Subgroup field display configs drupal-helfi-platform-config#646
• And this one UHF-9159: Subgroup field display configs. drupal-helfi-kasvatus-koulutus#481
• Aaand this one UHF-9159: Added subgroup accordion drupal-hdbt#825

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (42eed9b) 81.38% compared to head (3783cbc) 81.79%.
Report is 6 commits behind head on main.

❗ Current head 3783cbc differs from pull request most recent head 84d0c42. Consider uploading reports for the commit 84d0c42 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #161      +/-   ##
============================================
+ Coverage     81.38%   81.79%   +0.40%     
- Complexity      356      360       +4     
============================================
  Files            49       50       +1     
  Lines          2810     2873      +63     
============================================
+ Hits           2287     2350      +63     
  Misses          523      523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication