Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFH-8595: Added multiple missing fields to Units #147

Merged
merged 5 commits into from
Jun 22, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Jun 19, 2023

UHF-8595

Units are missing multiple fields from TPR.

What was done

  • Added four missing fields to unit entities (charges, further informations, web sites, other contact information)

How to install

  • Make sure your kuva instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi TPR config
    • composer require drupal/helfi_tpr:dev-UFH-8595_missing-unit-tpr-fields
    • composer require drupal/hdbt:dev-UHF-8595_missing-tpr-fields
    • composer require drupal/helfi_platform_config:dev-UHF-8595_tpr-unit-config-updates
  • Run make drush-updb drush-cr drush-local-update
  • Run the migration drush migrate:import tpr_unit --idlist 41047:fi,41047:sv,41047:en --update

How to test

Other PRs

Check also the other PRs which updates the unit template and display configs: City-of-Helsinki/drupal-hdbt#690 & City-of-Helsinki/drupal-helfi-platform-config#538.

Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works otherwise, but the field visibility settings are missing.

src/Entity/Unit.php Show resolved Hide resolved
src/Entity/Unit.php Show resolved Hide resolved
src/Field/Connection/Link.php Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.1% 7.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dire dire merged commit d44cc81 into main Jun 22, 2023
@dire dire deleted the UFH-8595_missing-unit-tpr-fields branch June 22, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants