Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8430: Added municipality to the address search query. #140

Merged
merged 1 commit into from
May 12, 2023
Merged

UHF-8430: Added municipality to the address search query. #140

merged 1 commit into from
May 12, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented May 9, 2023 •
edited
Loading

UHF-8430

What was done

This PR adds &municipality=Hhelsinki to the unit address search.

How to install

  • Make sure your kasko instance is up and running on latest dev branch (SOTE for example).
    • git pull origin dev
    • make fresh
  • Update the Helfi TPR module
    • composer require drupal/drupal-module-helfi-tpr:dev-UHF-8430-Unit-search-municipality-bug
  • Run make drush-cr

How to test

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Jussiles
Copy link
Contributor

TPR module composer spell should be: composer require drupal/helfi_tpr:dev-UHF-8430_Unit-search-municipality-bug

Jussiles
Jussiles approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wörks! 🦜

@dire dire merged commit e2f8518 into main May 12, 2023
@dire dire deleted the UHF-8430_Unit-search-municipality-bug branch May 12, 2023 05:01
This was referenced May 12, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jussiles Jussiles Jussiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dire @Jussiles