Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8837: Remove pages with X-Robots-Tag: noindex from sitemap #62

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Sep 4, 2023

UHF-8837

What was done

  • Helfi proxy module adds X-Robots-Tag: noindex to some configured pages. This change removes these pages from sitemap.xml.

How to install

How to test

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Merging #62 (e2c3437) into main (257e937) will not change coverage.
The diff coverage is n/a.

❗ Current head e2c3437 differs from pull request most recent head dc19d76. Consider uploading reports for the commit dc19d76 to get more accurate results

@@            Coverage Diff            @@
##               main      #62   +/-   ##
=========================================
  Coverage     66.40%   66.40%           
  Complexity       89       89           
=========================================
  Files            15       15           
  Lines           256      256           
=========================================
  Hits            170      170           
  Misses           86       86           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hyrsky hyrsky force-pushed the UHF-8837-remove-noindex-pages-from-sitemap branch from 61f9c2f to fb15957 Compare September 4, 2023 08:48
@hyrsky hyrsky force-pushed the UHF-8837-remove-noindex-pages-from-sitemap branch from fb15957 to cd70092 Compare September 4, 2023 08:52
@hyrsky hyrsky marked this pull request as ready for review September 4, 2023 08:54
helfi_proxy.module Outdated Show resolved Hide resolved
@hyrsky hyrsky force-pushed the UHF-8837-remove-noindex-pages-from-sitemap branch from 1d9c336 to 9ba6229 Compare September 4, 2023 10:00
@hyrsky hyrsky requested a review from tuutti September 4, 2023 10:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants