Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-4826: Automatic return URL detection for Tunnistamo return URL #46

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Nov 7, 2022

  • composer require drupal/helfi_tunnistamo:dev-UHF-4826
  • composer require drupal/helfi_proxy:dev-UHF-4826
  • drush cr

How to test:

  • Make sure you have no $config['helfi_proxy.settings']['tunnistamo_return_url'] overrides in your local.settings.php file
  • Open /user/login page and click Log in with Tunnistamo and make sure redirect_uri query parameter contains instance's Finnish proxy path. For example, KYMP should match /fi/kaupunkiymparisto-ja-liikenne/openid-connect/tunnistamo

Related PRs:

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tuutti tuutti changed the title UHF-4826: Automatically detect Tunnistamo return URL UHF-4826: Automatic return URL detection for Tunnistamo return URL Nov 7, 2022
@tuutti tuutti merged commit cae301f into main Nov 8, 2022
@tuutti tuutti deleted the UHF-4826 branch November 8, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants