Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-6865, UHF-7347: Removed RedirectResponseSubscriber because it conflicts with other redirects, like Tunnistamo logout #44

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Nov 1, 2022

To test this:

Make sure helfi-kymp.docker.so is redirected to proxy domain.

@codecov-commenter
Copy link

Codecov Report

Merging #44 (c2ac9f3) into main (e75e953) will decrease coverage by 46.66%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main      #44       +/-   ##
=============================================
- Coverage     73.33%   26.66%   -46.67%     
+ Complexity       15        4       -11     
=============================================
  Files             2        1        -1     
  Lines            45       15       -30     
=============================================
- Hits             33        4       -29     
+ Misses           12       11        -1     
Impacted Files Coverage Δ
...ore/EventSubscriber/RedirectResponseSubscriber.php

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tuutti tuutti changed the title UHF-6865: Removed RedirectResponseSubscriber because it conflicts with other redirects, like Tunnistamo logout UHF-6865, UHF-7347: Removed RedirectResponseSubscriber because it conflicts with other redirects, like Tunnistamo logout Nov 1, 2022
@tuutti tuutti merged commit d474a5f into main Nov 2, 2022
@tuutti tuutti deleted the UHF-6865 branch November 2, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants