Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9135: Simplify mobile fallback menu #48

Merged
merged 12 commits into from
Oct 24, 2023
Merged

UHF-9135: Simplify mobile fallback menu #48

merged 12 commits into from
Oct 24, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Oct 19, 2023

UHF-9135

How to install

  • composer require drupal/helfi_navigation:dev-UHF-9135
  • drush cr

How to test

  • todo

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #48 (41ade49) into main (ed63e6e) will increase coverage by 15.33%.
Report is 4 commits behind head on main.
The diff coverage is 63.04%.

❗ Current head 41ade49 differs from pull request most recent head f03cb15. Consider uploading reports for the commit f03cb15 to get more accurate results

@@              Coverage Diff              @@
##               main      #48       +/-   ##
=============================================
+ Coverage     70.83%   86.17%   +15.33%     
+ Complexity      177      162       -15     
=============================================
  Files            20       20               
  Lines           679      622       -57     
=============================================
+ Hits            481      536       +55     
+ Misses          198       86      -112     
Files Coverage Δ
src/ApiManager.php 100.00% <ø> (ø)
src/MainMenuManager.php 100.00% <ø> (ø)
src/Plugin/rest/resource/GlobalMobileMenu.php 93.33% <ø> (ø)
src/Menu/MenuTreeBuilder.php 95.28% <50.00%> (-0.88%) ⬇️
src/Plugin/Block/MobileMenuFallbackBlock.php 79.01% <63.63%> (+71.86%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems to work as it should, this fixes the bug. I'm unable to check the code quality tho as I'm not too familiar with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants