Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8526: Use PubSub to invalidate caches #42

Merged
merged 9 commits into from
Sep 16, 2023
Merged

UHF-8526: Use PubSub to invalidate caches #42

merged 9 commits into from
Sep 16, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Sep 13, 2023

UHF-8526

What was done

How to install

  • Make sure your instance is up and running on latest dev branch
  • Update navigation module: composer require drupal/helfi_navigation:dev-UHF-8526
  • Run make drush-cr

How to test

$config['helfi_api_base.api_accounts']['vault'][] = [
  'id' => 'helfi_navigation',
  'plugin' => 'authorization_token',
  'data' => base64_encode('helfi-admin:123'),
];
  • Etusivu: Make sure the password of helfi-admin account is 123: drush upwd helfi-admin 123
  • Etusivu and Liikenne: Start PubSub listener: drush helfi:azure:pubsub-listen
  • Liikenne: Modify a menu link in Main menu
  • Liikenne: Run drush cron
  • Liikenne: Make sure desktop menu navigation (hamburger menu) is updated instantly
  • Liikenne: Make sure mobile navigation is updated instantly
  • Etusivu: Update a non-main menu on Etusivu instance (header navigation for example)
  • Liikenne: Make sure header navigation is updated

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Merging #42 (5e6f875) into main (c2497e8) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

❗ Current head 5e6f875 differs from pull request most recent head 17abfd7. Consider uploading reports for the commit 17abfd7 to get more accurate results

@@             Coverage Diff              @@
##               main      #42      +/-   ##
============================================
- Coverage     70.25%   69.87%   -0.38%     
+ Complexity      177      169       -8     
============================================
  Files            20       19       -1     
  Lines           669      654      -15     
============================================
- Hits            470      457      -13     
+ Misses          199      197       -2     
Files Changed Coverage Δ
src/MainMenuManager.php 100.00% <ø> (ø)
src/Menu/MenuTreeBuilder.php 96.11% <ø> (ø)
src/ApiManager.php 100.00% <100.00%> (ø)
src/ExternalMenuTreeBuilder.php 100.00% <100.00%> (+1.40%) ⬆️
src/Plugin/QueueWorker/MenuQueue.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hyrsky hyrsky self-requested a review September 14, 2023 12:33
@hyrsky
Copy link
Contributor

hyrsky commented Sep 14, 2023

Ah, this was already assigned in Jira.

@hyrsky hyrsky removed their request for review September 14, 2023 12:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality approved, perfect 🦖

Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code and it look very clean. 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants