UHF-8738: prevent showing active trail on menuitem for link pointing to subdomain

[rpnykanen]

Fix bug causing an active trail being visible on Etusivu's frontpage's main navigation. Link to external site should never have active trail.

What was done

Added a check to make sure active trail is never added to a link pointing to subdomain.

How to install

• Setup etusivu and any other site
  • Follow the local development instructions in helfi_navigation module's readme

How to test

Reproduce bug

• other site: Edit an existing link or add new link (pointing helfi subdomain) in main navigation. (for example https://whatever.hel.fi/en)
  • This link should cause an active trail to be visible in Etusivu's english frontpage.
• other site: Run drush cron
• ETUSIVU: Run drush cr
• ETUSIVU: Go check front page. If you used the link mentioned previously, change language to english. Now there should be active trail indicator in main navigation.

Fix:

• ETUSIVU: Run composer require drupal/helfi_navigation:dev-UHF-8738_activetrail_subdomain
• Run drush cr
• Check the main navigation again
  • There should not be an active trail

Test the other site as well:

• other site: Run git checkout drupal/helfi_navigation:dev-UHF-8738_activetrail_subdomain
• other site: run drush cr
  • Main navigation should work as it worked before.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication