Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8522: Check target entity's view access for each menu link #36

Merged
merged 15 commits into from
Jun 2, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Jun 1, 2023

How to install

  • composer require drupal/helfi_navigation:dev-UHF-8522
  • drush cr
  • Start Etusivu instance (Etusivu doesn't need these changes)

How to test

  • Create a new node with menu link and unpublish the node
  • Run drush cron and make sure the menu link is not visible in Mega menu:
    image
  • Publish the node, run drush cron again, drush cr and make sure the menu link is now visible in Mega menu

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #36 (f5d119b) into main (b1ca890) will increase coverage by 18.78%.
The diff coverage is 90.76%.

❗ Current head f5d119b differs from pull request most recent head 1805ba2. Consider uploading reports for the commit 1805ba2 to get more accurate results

@@              Coverage Diff              @@
##               main      #36       +/-   ##
=============================================
+ Coverage     51.88%   70.66%   +18.78%     
- Complexity      168      173        +5     
=============================================
  Files            19       19               
  Lines           636      658       +22     
=============================================
+ Hits            330      465      +135     
+ Misses          306      193      -113     
Impacted Files Coverage Δ
src/EventSubscriber/RedirectEventSubscriber.php 100.00% <ø> (ø)
src/Plugin/rest/resource/GlobalMobileMenu.php 93.33% <85.00%> (+62.38%) ⬆️
src/Menu/MenuTreeBuilder.php 96.11% <88.00%> (-1.62%) ⬇️
src/ApiManager.php 100.00% <100.00%> (+2.06%) ⬆️
src/ExternalMenuTreeBuilder.php 98.55% <100.00%> (+95.77%) ⬆️
src/MainMenuManager.php 100.00% <100.00%> (ø)
src/Plugin/QueueWorker/MenuQueue.php 100.00% <100.00%> (+100.00%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tuutti tuutti changed the title UHF-8522: Check entity view access for each menu link UHF-8522: Check target entity's view access for each menu link Jun 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tuutti tuutti merged commit 29d0fc8 into main Jun 2, 2023
@tuutti tuutti deleted the UHF-8522 branch June 2, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants