Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9986: Monolog dependency #164

Merged
merged 10 commits into from
Apr 23, 2024
Merged

UHF-9986: Monolog dependency #164

merged 10 commits into from
Apr 23, 2024

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Apr 19, 2024

How to install

  • composer require drupal/helfi_api_base:dev-UHF-9986
  • Run drush updb

How to test

  • Make sure the monolog service is enabled after you run update hooks
  • Make sure errors are still logged into container stdout (docker compose logs app)
  • Make sure CLI commands don't output log messages directly to console (drush migrate:import for example)

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.07%. Comparing base (45489df) to head (179923f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #164      +/-   ##
============================================
+ Coverage     82.05%   82.07%   +0.01%     
+ Complexity      561      557       -4     
============================================
  Files            76       76              
  Lines          1906     1908       +2     
============================================
+ Hits           1564     1566       +2     
  Misses          342      342              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from UHF-9635 to main April 19, 2024 12:21
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants