Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9088: Helfi locale-import #152

Merged
merged 5 commits into from
Mar 25, 2024
Merged

UHF-9088: Helfi locale-import #152

merged 5 commits into from
Mar 25, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Mar 8, 2024

Added override flag to helfi:locale-import to actually override the translations.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.36%. Comparing base (778b643) to head (b6a8f2c).

❗ Current head b6a8f2c differs from pull request most recent head e8db70c. Consider uploading reports for the commit e8db70c to get more accurate results

Files Patch % Lines
src/Commands/LocaleCommands.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #152      +/-   ##
============================================
- Coverage     67.40%   67.36%   -0.04%     
  Complexity      540      540              
============================================
  Files            73       73              
  Lines          1850     1851       +1     
============================================
  Hits           1247     1247              
- Misses          603      604       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

khalima added 4 commits March 13, 2024 15:13
…pot files before importing them. The functionality has changed after platform config v3 update. Also tweaked the settings of how the translations imported to database; override only not-customized translations and set the imported translations as not-customized.
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants