Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8525: Fixed api account commands to work with secrets longer than 4096 characters #127

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Sep 6, 2023

Terminals seems to truncate everything after the first 4096 characters. See https://github.com/symfony/symfony/blob/6.4/src/Symfony/Component/Console/Helper/QuestionHelper.php#L446C40-L446C40

Older symfony/console versions doesn't seem to show a warning when the message is truncated, so I've added instructions to use --filename option instead when dealing with long secrets.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Merging #127 (983c0b1) into main (834d8ba) will decrease coverage by 0.20%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 983c0b1 differs from pull request most recent head c937db2. Consider uploading reports for the commit c937db2 to get more accurate results

@@             Coverage Diff              @@
##               main     #127      +/-   ##
============================================
- Coverage     64.44%   64.25%   -0.20%     
- Complexity      472      474       +2     
============================================
  Files            66       66              
  Lines          1654     1659       +5     
============================================
  Hits           1066     1066              
- Misses          588      593       +5     
Files Changed Coverage Δ
src/Commands/ApiAccountCommands.php 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants