-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-8636: debug page item for indexed items #121
Conversation
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
============================================
- Coverage 64.19% 63.01% -1.18%
- Complexity 464 477 +13
============================================
Files 65 66 +1
Lines 1631 1671 +40
============================================
+ Hits 1047 1053 +6
- Misses 584 618 +34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a simple test as well, especially the conditional construction logic. See https://github.com/City-of-Helsinki/drupal-module-helfi-api-base/blob/main/tests/src/Unit/ComposerDataItemTest.php for example
* | ||
* @var null | ||
*/ | ||
protected $clientManager = NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing property type
* | ||
* @var null | ||
*/ | ||
protected $clusterManager = NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing property type.
Nevermind. We should move this to |
UHF-8636
Allow showing SearchApi index status on dashboard
How to install
Select one of the environments with elasticsearch set up (Kasko for example)
You should also test this with a site without searchapi enabled to make sure nothing breaks.
How to test
/api/v1/debug
helfi_search_api_index
key within the resultrun the indexing or rebuild the index
./admin/config/search/search-api
School
in kasko)Rebuild tracking information
1 batch of 50 items
(50/134000)
Index up to date
.Test this with any other site without elasticsearch (kuva?). Open the api search result and you should see it.
Also open debug page and see that it works as well.
Other PRs