Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLATTA-4937: compute only once for active project and active env name #117

Merged
merged 3 commits into from
Jun 21, 2023
Merged

PLATTA-4937: compute only once for active project and active env name #117

merged 3 commits into from
Jun 21, 2023

Conversation

oviag
Copy link
Contributor

@oviag oviag commented Jun 16, 2023

Issue: https://helsinkisolutionoffice.atlassian.net/browse/PLATTA-4937

Refactor computation logic to retrieve only one time the config for active project and active environment.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023 •
edited
Loading

Codecov Report

Merging #117 (7032088) into main (af41c08) will increase coverage by 0.03%.
The diff coverage is 83.33%.

❗ Current head 7032088 differs from pull request most recent head 6c45a54. Consider uploading reports for the commit 6c45a54 to get more accurate results

@@             Coverage Diff              @@
##               main     #117      +/-   ##
============================================
+ Coverage     62.43%   62.46%   +0.03%     
- Complexity      439      441       +2     
============================================
  Files            64       64              
  Lines          1560     1564       +4     
============================================
+ Hits            974      977       +3     
- Misses          586      587       +1
Impacted Files Coverage Δ
src/Environment/EnvironmentResolver.php 97.40% <83.33%> (-1.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@juho-lehmonen juho-lehmonen self-requested a review June 20, 2023 09:59
tuutti
tuutti requested changes Jun 21, 2023
View reviewed changes
src/Environment/EnvironmentResolver.php Outdated Show resolved Hide resolved
src/Environment/EnvironmentResolver.php Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tuutti
tuutti approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@tuutti tuutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

dragos-dumi-ibm
dragos-dumi-ibm approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@dragos-dumi-ibm dragos-dumi-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@oviag oviag merged commit b178224 into main Jun 21, 2023
@oviag oviag deleted the PLATTA-4937 branch June 21, 2023 10:52
@dragos-dumi-ibm dragos-dumi-ibm changed the title compute only once for active project and active env name PLATTA-4937: compute only once for active project and active env name Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragos-dumi-ibm dragos-dumi-ibm dragos-dumi-ibm approved these changes

@tuutti tuutti tuutti approved these changes

@rpnykanen rpnykanen Awaiting requested review from rpnykanen

@juho-lehmonen juho-lehmonen Awaiting requested review from juho-lehmonen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oviag @codecov-commenter @tuutti @dragos-dumi-ibm