Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8716: Enable Askem (React & Share) to service pages #490

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Aug 16, 2023

UHF-8716

What was done

  • Limited the Askem (React & Share) block to be hidden only on news pages.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-8716_enable_askem_to_service_pages
    • make fresh
  • Run make drush-cr

How to test

  • Check that the Askem (React & Share) block is now visible on TPR Service and TPR Unit where it wasn't visible before.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

…pe, enable the functionality to all content except news pages
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dire dire self-requested a review August 18, 2023 05:40
Copy link
Contributor

@dire dire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

Some news items didn't have path alias so the block was visible on them, so a content type based restriction could be more flawless.

But anyway, news items without aliases shouldn't exist, so approved!

@teroelonen
Copy link
Contributor Author

Yeah, had to use the path based restriction here because the content type restriction limits the block to only nodes and we need the Askem to be visible on TPR-entities.

@teroelonen teroelonen merged commit 08da1f9 into dev Aug 18, 2023
@teroelonen teroelonen deleted the UHF-8716_enable_askem_to_service_pages branch August 18, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants