Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-7006: Browserslist db automatic update #452

Merged
merged 1 commit into from
May 11, 2023
Merged

UHF-7006: Browserslist db automatic update #452

merged 1 commit into from
May 11, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented May 9, 2023 •
edited
Loading

UHF-7006

What was done

  • Added preinstall for package.json that checks if there is updates for browserslist db

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-7006_browserslist_db_automatic_update
  • Go under the hdbt_subtheme theme and run nvm use && npm i && npm run build
    • The theme compiling should now say at some point:
> [email protected] preinstall
> npx browserslist@latest --update-db

How to test

  • There is nothing more to check here. This is intended to keep our browserslists fresh in the future.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

This was referenced May 9, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

khalima
khalima approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@teroelonen teroelonen merged commit 221f37b into dev May 11, 2023
@teroelonen teroelonen deleted the UHF-7006_browserslist_db_automatic_update branch May 11, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima