Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uhf 9193 maternity clinic search #732

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Uhf 9193 maternity clinic search #732

merged 6 commits into from
Dec 22, 2023

Conversation

j-mys
Copy link
Contributor

@j-mys j-mys commented Dec 22, 2023 •
edited
Loading

UHF-9193

What was done

  • Add maternity clinics search to config

How to test

City-of-Helsinki/drupal-hdbt#865

@j-mys j-mys mentioned this pull request Dec 22, 2023
Merged
5 tasks
Jussiles
Jussiles suggested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but added couple of comments that should be fixed before the merge.

...cmi/field.field.paragraph.maternity_and_child_health_clini.field_comp_search_description.yml Outdated Show resolved Hide resolved
conf/cmi/field.field.node.landing_page.field_content.yml Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Jussiles
Jussiles approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its good now! good work! hyvää joulua! merry christmas! 🎄

@j-mys j-mys merged commit 04f4de9 into dev Dec 22, 2023
2 checks passed
@j-mys j-mys deleted the UHF-9193_maternity_clinic_search branch December 22, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jussiles Jussiles Jussiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-mys @Jussiles