UHF-9937: Make sure removed job listings are not published

[hyrsky]

UHF-9937

What was done

helfi_rekry_jobs:changed migration does not work that well for removed job listings. For context, the helfi_rekry_jobs:changed migraton uses timestamp query parameter in a Helbit API URL to list all job listings that have changed since the timestamp. The timestamp comes from -1 day in the migration source plugin. However, this query shows a job listing HELBIT-01-17-24, which is not visible without the timestamp query parameters, since it was deleted between 12:00 - 13:00.

So, if a job listing is deleted, helfi_rekry_jobs:changed will return invalid data for at least a day. I thought that it would be best just to not use the changed migration at all.

Also, job listings are marked unpublished when they disappear from the helfi_rekry_jobs:all migration. This is detected with a MigrateMissingSourceRowsEvent event handler. The event handler does not take into account job listings that are currently unpublished, but are scheduled to be published later.

How to install

• Make sure your instance is up and running on correct branch.
  • git checkout UHF-9937-removed-job-listings
  • make fresh
• Run make drush-cr

How to test

• Reproducing the bug required to manually change code that passes query parameters to the helbit api: https://github.com/City-of-Helsinki/drupal-helfi-rekry/blob/dev/public/modules/custom/helfi_rekry_content/src/Plugin/migrate/source/HelbitOpenJobs.php#L51-L55.
• Check that code follows our standards

Continuous documentation

• This feature has been documented/the documentation has been updated
• This change doesn't require updates to the documentation

Translations

• Translations have been added to .po -files and included in this PR

Other PRs

• Link to other PR

[jeremysteerio]

Since running the helfi_rekry_jobs migration is moved out of migrate-job-listings.sh, should we change names of the script files to reflect what's going on better?

Also might be worthwhile to strip changed derivative from HelbitMigrationDeriver file.