Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10941: Hakuvahti Sentry error #604

Merged
merged 3 commits into from
Nov 19, 2024
Merged

UHF-10941: Hakuvahti Sentry error #604

merged 3 commits into from
Nov 19, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Nov 19, 2024

UHF-10941

What was done

  • Debug Sentry issue: https://sentry.hel.fi/organizations/city-of-helsinki/issues/35962/?project=93&referrer=slack
    • Hakuvahti responds with 404 if:
      • Submission has been deleted after (UNCONFIRMED_SUBSCRIPTION_MAX_AGE).
      • Submission has already been confirmed.
    • I did not find a anything odd in the behaviour.
    • Changed the logging so that if hakuvahti responds with 404, no errors are logged to Sentry.
  • Fixed unrelated elasticsearch issue: Task area & Type of employment inputs in search form do not work because of elasticseach_connector v8 ugprade.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10941
    • make fresh
  • Run make drush-cr

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

@juho-lehmonen juho-lehmonen self-requested a review November 19, 2024 07:16
@hyrsky hyrsky merged commit 5aa591e into dev Nov 19, 2024
2 checks passed
@hyrsky hyrsky deleted the UHF-10941 branch November 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants