Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10906 Job listing refactor #588

Merged
merged 12 commits into from
Nov 4, 2024
Merged

UHF-10906 Job listing refactor #588

merged 12 commits into from
Nov 4, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Nov 4, 2024 •
edited
Loading

UHF-10906

What was done

  • Refactored job listing organization information block

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10906_job_listing_cherry_pick
    • make fresh
  • Run make drush-cr

How to test

  • Check that the organization information block works as before
  • Check that code follows our standards

tuutti and others added 12 commits November 1, 2024 11:45
@tuutti
UHF-10906: Potential fix for #UHF-10906
0bb6290
@khalima
Merge pull request #585 from City-of-Helsinki/UHF-10906-2
78522a8 
UHF-10906: Potential fix for #UHF-10906
@rpnykanen
Merge pull request #583 from City-of-Helsinki/UHF-10619
0660161 
UHF-10619
@khalima
Removed the organization information block preprocess.
25c2575
@khalima
Use variables instead of render element information in organization i…
53665f3 
…nformation block template.
@khalima
Refactored the organization information block to use the JobListing b…
223d05a 
…undle class.
@khalima
Moved the render array build to the block build.
cddbf65
@khalima
Simplify the organization information getters.
9c3071c
@khalima
Use the term interface instead of entity interface.
1351f1a
@khalima
New method for getting a translated taxonomy term title.
9d8ee8d
@khalima
Fixed the render array for the joblisting image field.
5501235
@khalima
Removed unused use statement.
abff0f7
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@khalima khalima changed the base branch from dev to UHF-10619 November 4, 2024 14:37
@khalima khalima merged commit 18cf9f4 into UHF-10619 Nov 4, 2024
2 checks passed
@khalima khalima deleted the UHF-10906_job_listing_cherry_pick branch November 4, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpnykanen rpnykanen rpnykanen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khalima @rpnykanen @tuutti