Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X parameter handling fix #525

Merged
merged 15 commits into from
Jul 16, 2024
Merged

UHF-X parameter handling fix #525

merged 15 commits into from
Jul 16, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Jul 15, 2024

UHF-10194

Parameter handling was inadequate.

What was done

Fixed the parameter logic
Refactored subscription controller

  • Autowiring, added new dependencies to class etc.
  • Functions in completely random order,
  • Handle translations with match instead of //phpcsignore

How to install

  • Read the documentation

How to test

  • Read the documentation

  • Check that this feature works

  • Check that code follows our standards

Other PRs

---- TBD -----

  • Link to other PR

@rpnykanen rpnykanen changed the title UHF-X parameters to email fix UHF-X parameter handling fix Jul 15, 2024
Copy link

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes plenty of issues 🦖

@rpnykanen rpnykanen merged commit 9fd98ce into dev Jul 16, 2024
2 checks passed
@rpnykanen rpnykanen deleted the UHF-X_hav_fixes branch July 16, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants