Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hakuvahti SonarCloud changes. #479

Merged
merged 15 commits into from
May 28, 2024
Merged

Hakuvahti SonarCloud changes. #479

merged 15 commits into from
May 28, 2024

Conversation

sundflux
Copy link
Contributor

@sundflux sundflux commented May 27, 2024

UHF-10005

SonarCloud complains about duplicate code.

What was done

This PR merges unsubcribe and confirm controllers into a single controller with shared twig templates for form and layout.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout hakuvahti_X-sc_changes
    • make fresh
  • Run make drush-cr

How to test

  • Subscribe for hakuvahti on the job search page and check that layout works.
  • Click subscribe link in the mail and check that layout works.
  • Check that unsubscribe layout works. Quick hack: change "confirm" to "unsubscribe" in the confirmation URL.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

@sundflux sundflux requested a review from teroelonen May 27, 2024 16:20
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one works for me now nicely 🦖

Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@teroelonen teroelonen merged commit 7ce57a3 into hakuvahti May 28, 2024
2 checks passed
@teroelonen teroelonen deleted the hakuvahti-X-sc_changes branch May 28, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants