UHF-8478: Remove deprecated helfi_rekry_job_search module #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
Jussiles
suggested changes
Nov 14, 2023
| @@ -1,5 +1,5 @@ | |||
| search_page: '2971' | |||
| redirect_403_page: '2971' | |||
| redirect_403_page: '4848' | |||
There was a problem hiding this comment.
I guess we don't want to change this value at least with this PR. This change should be reverted.
There was a problem hiding this comment.
Reverted this config
| @@ -323,6 +314,7 @@ datasource_settings: | |||
| processor_settings: | |||
| add_url: { } | |||
| aggregated_field: { } | |||
| custom_value: { } | |||
There was a problem hiding this comment.
What is this change? Is this needed?
| * | ||
| * Update job search's task area pages metadata. | ||
| */ | ||
| function helfi_rekry_job_search_page_attachments_alter(array &$attachments) { |
There was a problem hiding this comment.
Did you move the contents of this file somewhere? These functions are needed and they should be moved under helfi_rekry_content.module
There was a problem hiding this comment.
These codes are now copied to helfi_rekry_content.module
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-8478
What was done
field_copiedfield from node typejob_listinghelfi_rekry_job_searchHow to install
git checkout UHF-8478_Remove_field_copiedmake freshmake drush-crHow to test
job_listingdoesn't have fieldfield_copiedhelfi_rekry_job_searchis removedDesigners review
Other PRs