-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-8946: redirect to existing job listing translation #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…direct them to the existing translation if one can be found
tuutti
approved these changes
Sep 14, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
hyrsky
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-8946
External system is only capable of creating links to finnish job listings. If job listing doesn't have finnish translation the user would see 404 page.
What was done
Added 404 exception listener which redirect user from untranslated job listing to the existing translation if it exists.
How to install
git checkout UHF-8946_job_redirect
make fresh
make drush-cr
How to test
/sv/lediga-jobb/lediga-jobb/{job_recruitment_id}
to/fi/avoimet-tyopaikat/avoimet-tyopaikat/{job_recruitment_id}
Other things to try out:
/fi/avoimet-tyopaikat/avoimet-tyopaikat/
, for example non existing recruitment id