Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8520 JS translation fix #262

Merged
merged 3 commits into from
May 24, 2023
Merged

UHF-8520 JS translation fix #262

merged 3 commits into from
May 24, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented May 23, 2023 •
edited
Loading

UHF-8520

What was done

  • Stopped the TerserPlugin from minifying the variable names Drupal and drupalSettings.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-8520_js_translation_fix
    • make fresh
  • Run make drush-cr

How to test

  • Check that the site theme still works as it should.
  • Test that the siteimprove analytics still works as it should if possible.
  • You can also check the testing instructions from hdbt PR.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

This was referenced May 23, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
khalima
khalima approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that the common.min.js isn't loaded by any library. Otherwise good job! 🚀

@teroelonen
Copy link
Contributor Author

Removed common.js altogether.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teroelonen teroelonen merged commit 7624e92 into dev May 24, 2023
@teroelonen teroelonen deleted the UHF-8520_js_translation_fix branch May 24, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima