Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8510: Document commands for building assets in containers #148

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Aug 18, 2023

UHF-8510

What was done

Make commands for compiling the theme were already documented in City-of-Helsinki/drupal-helfi-platform repository. This PR adds description of the commands to this repository so they are easier to find.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8510-document-theme-build-commands

How to test

  • Follow README.md instructions.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@juho-lehmonen juho-lehmonen self-requested a review August 21, 2023 07:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hyrsky hyrsky merged commit 9129dbe into main Aug 24, 2023
@hyrsky hyrsky deleted the UHF-8510-document-theme-build-commands branch August 24, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants