Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11186 CKEditor link plugin #873

Merged
merged 6 commits into from
Dec 19, 2024
Merged

UHF-11186 CKEditor link plugin #873

merged 6 commits into from
Dec 19, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Dec 19, 2024

UHF-11186

What was done

  • Changed the _getBalloonPosition() to getPositionOptions().
  • Reverted the conflict rule for Drupal core.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-11186
  • Run make drush-updb drush-cr

How to test

  • Check that Drupal is updated to 10.4. and check that the CKEditor link plugin works as it should
    • This is broken:
      image
    • This is functions properly:
      image
  • Check that code follows our standards

@khalima khalima mentioned this pull request Dec 19, 2024
2 tasks
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.87%. Comparing base (7c52e54) to head (c39e1d9).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #873   +/-   ##
=========================================
  Coverage     17.87%   17.87%           
  Complexity      285      285           
=========================================
  Files            36       36           
  Lines          1080     1080           
=========================================
  Hits            193      193           
  Misses          887      887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants