Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10908 Cookie settings page #864

Merged
merged 15 commits into from
Dec 10, 2024
Merged

UHF-10908 Cookie settings page #864

merged 15 commits into from
Dec 10, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Dec 10, 2024 •
edited by jira bot
Loading

UHF-10908

What was done

  • Translated the cookie settings page link

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10908_cookie_settings_page
  • Run make drush-cr

How to test

  • Check that the cookie settings page links point to helfi-etusivu if the site uses global settings
  • Check that code follows our standards

khalima and others added 15 commits December 4, 2024 07:58
@khalima
UHF-10908: Use variable for the spacerParentSelector, if it is set.
900be57
@khalima
UHF-10908: Added hdbt_cookie_banner_test module to alter settings in …
870a12e 
…tests.
@khalima
UHF-10908: Added test for the cookie banner functionality.
bc452d5
@khalima
UHF-10908: Fixed phpstan error.
3a7ce03
@tuutti
UHF-10908: Testing fixes
dc45cd1
@khalima
UHF-10908: Get cookie settings page URL with a langcode.
af42bf7
@khalima
UHF-10908: Reverted the custom cookie consent JS injection, until it'…
ed62b5f 
…s properly removed.
@khalima
UHF-10908: Test the cookie banner settings page url with languages.
ea093bb
@khalima
UHF-10908: Updated the siteSettingsTemplate.json.
740876b
@khalima
UHF-10908: Updated the cookie banner functional test.
32eb0da
@khalima
UHF-10908: Use current language if getCookieSettingsPageUrl is called…
411fc8b 
… without the language parameter.
@khalima
UHF-10908: Fixed PHPCS.
8bc67e7
@khalima
UHF-10908: Reverted the changes for functional cookie banner tests un…
983959a 
…til the CI pipeline is updated.
@khalima
UHF-10908: Merge branch 'main' of https://github.com/City-of-Helsinki…
f7eab9c 
…/drupal-helfi-platform-config into UHF-10908_cookie_settings_page
@khalima
UHF-10908: Moved the UnapprovedItemError class outside of the eventli…
8b3db16 
…stener.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khalima khalima merged commit 392d323 into main Dec 10, 2024
5 checks passed
@khalima khalima deleted the UHF-10908_cookie_settings_page branch December 10, 2024 07:26
This was referenced Dec 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpnykanen rpnykanen rpnykanen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khalima @rpnykanen @tuutti