Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X Accordion paragraphs weights #863

Merged
merged 4 commits into from
Dec 10, 2024
Merged

UHF-X Accordion paragraphs weights #863

merged 4 commits into from
Dec 10, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Dec 9, 2024

What was done

  • Sorted the accordion paragraphs in the following order: text, image, phasing, columns

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_accordion_paragraph_weight
  • Run make drush-updb drush-cr

How to test

  • Check that this feature works
  • Check that code follows our standards

teroelonen
teroelonen approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so good idea 🦖

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khalima khalima merged commit abb361b into main Dec 10, 2024
5 checks passed
@khalima khalima deleted the UHF-X_accordion_paragraph_weight branch December 10, 2024 06:17
This was referenced Dec 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen