Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11039: Updated hds cookie consent to use 4.0.0 version #857

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Nov 28, 2024

UHF-11039

What was done

  • HDS cookie consent was updated to 4.0.0

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-11039
  • Run make drush-updb drush-cr

How to test

  • Before testing the banner, update the cookie settings to use the updated json with correct new variables etc. To update the json, have you etusivu instance running and add the new json here. Other instances will now use the json from etusivu if you keep it running while testing the other instances.
  • Test that the cookie banner still works and has black theme in use
  • Test that the cookie banner still sends unapproved cookies to sentry (see instructions here)
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

@juho-lehmonen juho-lehmonen self-requested a review November 29, 2024 11:40
Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third party embeds are broken with the new JSON version. Otherwise working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants