Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10570: Aria label and role for the IBM chats with JavaScript #853

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Nov 26, 2024

UHF-10570

What was done

  • Merge user consent functionality with chat accessibility enhancements
  • Create one new library, attach it to IbmChatApp

How to install

  • Make sure your instance is up and running on latest dev branch. Instances with chats can be found from here but for example asuminen or sote is good place to start.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10570
  • Run make drush-updb drush-cr

How to test

  • Go to any instance with a IBM chat (for example asuminen or sote) and inspect the chat button that there is now the role="region" and aria-labelledby="chat-app-button" for the chat button.
  • Check that the chat still works normally.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

@teroelonen teroelonen marked this pull request as ready for review November 26, 2024 11:29
Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as described!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants