Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10841 CKEditor Link plugin to support # #834

Merged
merged 3 commits into from
Oct 24, 2024
Merged

UHF-10841 CKEditor Link plugin to support # #834

merged 3 commits into from
Oct 24, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Oct 24, 2024

UHF-10841

What was done

  • Skip the checks for URL protocol and external URLs if href value starts with #.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10841
  • Run make drush-cr

How to test

  • Check that the anchor hrefs starting with # doesn't break the CKEditor
  • Check that code follows our standards

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants