Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10179 Cookie descriptions #818

Merged
merged 2 commits into from
Oct 2, 2024
Merged

UHF-10179 Cookie descriptions #818

merged 2 commits into from
Oct 2, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Sep 26, 2024

UHF-10179

What was done

  • Removed duplicated editoria11yResultCount cookie and converted the custom translations to their actual names.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10179_fixed
  • Run make drush-updb drush-cr

How to test

  • Check the /{en|fi|sv}/cookie-information-and-settings-page, that there are no double mentions of editoria11yResultCount cookie.
  • Check the /{fi|sv}/cookie-information-and-settings-page, that the custom translations for Local storage and Session storage have been converted back to their actual names
  • Check that code follows our standards

Copy link

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants